fix(html): skip HTML balance warnings when Handlebars is present#3098
Closed
leno23 wants to merge 1 commit into
Closed
fix(html): skip HTML balance warnings when Handlebars is present#3098leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Handlebars helpers such as `{{#include}}` are expanded after the HTML
tree is built. Validating tag balance on the pre-expansion source caused
false positives for patterns like `<details>...{{#include ...}}</details>`
inside admonitions.
Fixes rust-lang#2941.
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@leno23 I see that you've opened a large number of PRs using an AI tool. Please do not do that. Per the contributing guide, we are unable to review these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{...}}).{{#include}}are expanded after the HTML tree is built; validating tag balance on the pre-expansion source produced false positives (e.g.<details>wrapping an include inside an admonition).Fixes #2941.
Test plan
cargo test -p mdbook html_with_handlebarsunclosed_html_tagstest still passes (real unclosed tags still warn)Made with Cursor